ansible-roles/docker_systemd_service
ansible-roles/docker_systemd_service
4
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

support all docker arguments #2

Merged
lanson merged 10 commits from feature/support-all-docker-args into main 2023-12-10 18:09:49 +00:00
Conversation 1 Commits 10 Files Changed 22 +412 -166
lanson commented 2023-12-09 16:27:32 +00:00
Owner
Copy Link

This aims to fix #1

Mainly there are 3 types of flags:

  • Flags with no data
  • Flags that can only be passed once
  • Flags that can be passed multiple times
This aims to fix #1 Mainly there are 3 types of flags: - [x] Flags with no data - [x] Flags that can only be passed once - [x] Flags that can be passed multiple times
lanson added 2 commits 2023-12-09 16:27:32 +00:00
feat(template): add support for passing all docker run arguments
All checks were successful
test / Linting (push) Successful in 9s
Details
4725483303
feat(readme): credits mhutter for original material
All checks were successful
test / Linting (push) Successful in 6s
Details
84aac3e716
lanson commented 2023-12-09 16:31:20 +00:00
Author
Owner
Copy Link

The new implementation should take a single variable:

docker_systemd_service_flags: []

This is a list that can take multiple types as items:

  • string for flags that do not take data parameters
  • map(string) for flags that can only be added once, and take a data parameter
  • map(list) for flags that can be passsed multiple times and take data parameters
The new implementation should take a single variable: ```yaml docker_systemd_service_flags: [] ``` This is a list that can take multiple types as items: - `string` for flags that do not take data parameters - `map(string)` for flags that can only be added once, and take a data parameter - `map(list)` for flags that can be passsed multiple times and take data parameters
lanson added 1 commit 2023-12-09 16:47:38 +00:00
feat(template): add support for simple string flags
All checks were successful
test / Linting (push) Successful in 9s
Details
2c275b9f1c
lanson added 1 commit 2023-12-09 17:20:58 +00:00
lanson added 1 commit 2023-12-09 17:36:30 +00:00
feat(template): move flag formatting to filter_plugin
All checks were successful
test / Linting (push) Successful in 8s
Details
562fc0215e
lanson added 1 commit 2023-12-09 18:47:04 +00:00
feat(readme): update documentation on variables
All checks were successful
test / Linting (push) Successful in 9s
Details
d15bce04de
lanson added 1 commit 2023-12-10 16:32:56 +00:00
feat(tests): add testing for the default values on both docker and vagrant
All checks were successful
test / Linting (push) Successful in 34s
Details
f813944d74
lanson added 1 commit 2023-12-10 17:25:46 +00:00
feat(tests): added custom tests for both vagrant and docker
All checks were successful
test / Linting (push) Successful in 10s
Details
9b6bf1684e
lanson added 1 commit 2023-12-10 17:26:57 +00:00
feat(cicd): add unit testing jobs
Some checks failed
test / Linting (push) Successful in 8s
Details
test / Molecule tests (default, debian11) (push) Successful in 49s
Details
test / Molecule tests (default, ubuntu2004) (push) Successful in 1m17s
Details
test / Molecule tests (with_custom_config, debian11) (push) Failing after 3s
Details
test / Molecule tests (default, debian12) (push) Successful in 1m23s
Details
test / Molecule tests (with_custom_config, debian12) (push) Failing after 3s
Details
test / Molecule tests (with_custom_config, ubuntu2004) (push) Failing after 3s
Details
test / Molecule tests (default, ubuntu2204) (push) Successful in 54s
Details
test / Molecule tests (with_custom_config, ubuntu2204) (push) Failing after 2s
Details
e25f838a8d
lanson added 1 commit 2023-12-10 17:50:21 +00:00
fix: change test scenario names in CICD
All checks were successful
test / Linting (push) Successful in 10s
Details
test / Molecule tests (default, ubuntu2004) (push) Successful in 1m10s
Details
test / Molecule tests (default, debian12) (push) Successful in 1m13s
Details
test / Molecule tests (default, debian11) (push) Successful in 1m19s
Details
test / Molecule tests (with_custom_flags, debian11) (push) Successful in 31s
Details
test / Molecule tests (default, ubuntu2204) (push) Successful in 1m0s
Details
test / Molecule tests (with_custom_flags, debian12) (push) Successful in 1m9s
Details
test / Molecule tests (with_custom_flags, ubuntu2004) (push) Successful in 53s
Details
test / Molecule tests (with_custom_flags, ubuntu2204) (push) Successful in 34s
Details
4b1ea01f3b
lanson changed title from WIP: support all docker arguments to support all docker arguments 2023-12-10 17:54:39 +00:00
lanson merged commit 2efc8bf638 into main 2023-12-10 18:09:49 +00:00
lanson deleted branch feature/support-all-docker-args 2023-12-10 18:09:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: ansible-roles/docker_systemd_service#2
No description provided.
Delete Branch "feature/support-all-docker-args"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?