From 0f61134f89fc03ed573217041433f3845aaa86ae Mon Sep 17 00:00:00 2001
From: Bertrand Lanson <bertrand.lanson@protonmail.com>
Date: Sat, 13 Apr 2024 22:51:04 +0200
Subject: [PATCH] feat(variables): remove ext_subnet_id variable

---
 README.md    |  1 -
 variables.tf | 20 ++++++++++----------
 2 files changed, 10 insertions(+), 11 deletions(-)

diff --git a/README.md b/README.md
index af5fc01..ae4ff53 100644
--- a/README.md
+++ b/README.md
@@ -59,7 +59,6 @@ No modules.
 | <a name="input_database_subnet_prefix_len"></a> [database_subnet_prefix_len](#input_database_subnet_prefix_len) | The prefix length of the database subnet. Must be between 24 and 32. | `number` | `24` | no |
 | <a name="input_database_subnetpool_id"></a> [database_subnetpool_id](#input_database_subnetpool_id) | The id of the subnetpool to create the databse network from.<br>Since this module can route private subnets to the backbone, it needs to make sure it's not creating overlapping subnets. | `string` | `null` | no |
 | <a name="input_external_network_id"></a> [external_network_id](#input_external_network_id) | The id of the external network to connect the frontend router to. | `string` | `null` | no |
-| <a name="input_external_subnet_id"></a> [external_subnet_id](#input_external_subnet_id) | The id of the external subnet to connect the frontend router to. | `string` | `null` | no |
 | <a name="input_frontend_subnet_prefix_len"></a> [frontend_subnet_prefix_len](#input_frontend_subnet_prefix_len) | The prefix length of the frontend subnet. Must be between 20 and 32. | `number` | `24` | no |
 | <a name="input_project_domain"></a> [project_domain](#input_project_domain) | The domain where this project will be created | `string` | `"default"` | no |
 | <a name="input_project_name"></a> [project_name](#input_project_name) | The name of the project | `string` | n/a | yes |
diff --git a/variables.tf b/variables.tf
index 24211b6..435971d 100644
--- a/variables.tf
+++ b/variables.tf
@@ -191,11 +191,11 @@ variable "external_network_id" {
   default     = null
 }
 
-variable "external_subnet_id" {
-  type        = string
-  description = "The id of the external subnet to connect the frontend router to."
-  default     = null
-}
+# variable "external_subnet_id" {
+#   type        = string
+#   description = "The id of the external subnet to connect the frontend router to."
+#   default     = null
+# }
 
 locals {
   validate_external_network_id = (
@@ -203,9 +203,9 @@ locals {
     var.attach_to_external &&
     var.external_network_id == null
   ) ? tobool("Please pass in the external network ID to attach the frontend router to.") : true
-  validate_external_subnet_id = (
-    var.architecture_tiers > 0 &&
-    var.attach_to_external &&
-    var.external_subnet_id == null
-  ) ? tobool("Please pass in the external subnet ID to attach the frontend router to.") : true
+  # validate_external_subnet_id = (
+  #   var.architecture_tiers > 0 &&
+  #   var.attach_to_external &&
+  #   var.external_subnet_id == null
+  # ) ? tobool("Please pass in the external subnet ID to attach the frontend router to.") : true
 }