From 9ceb90e925b2813b0b60868dcbad8859ac5f3b5e Mon Sep 17 00:00:00 2001
From: Bertrand Lanson <bertrand.lanson@protonmail.com>
Date: Sun, 30 Jul 2023 15:06:45 +0200
Subject: [PATCH] remove auto-install dependencies, to make roles more standard

---
 README.md                         | 3 ++-
 molecule/default/requirements.yml | 5 +++++
 tasks/prerequisites.yml           | 9 ---------
 vars/main.yml                     | 3 ---
 4 files changed, 7 insertions(+), 13 deletions(-)
 create mode 100644 molecule/default/requirements.yml

diff --git a/README.md b/README.md
index 4cab7ed..295435a 100644
--- a/README.md
+++ b/README.md
@@ -92,7 +92,8 @@ This variable defines whether or not to start the service after creating it. By
 Dependencies
 ------------
 
-This role has a task that installs its own dependencies located in `task/prerequisites.yml`, so that you don't need to manage them. This role requires both `ednxzu.manage_repositories` and `ednxzu.manage_apt_packages` to install consul-template.
+`ednxzu.manage_repositories` to configure hashicorp apt repository.
+`ednxzu.manage_apt_packages` to install consul-template.
 
 Example Playbook
 ----------------
diff --git a/molecule/default/requirements.yml b/molecule/default/requirements.yml
new file mode 100644
index 0000000..0a4a9fb
--- /dev/null
+++ b/molecule/default/requirements.yml
@@ -0,0 +1,5 @@
+---
+# requirements file for molecule
+roles:
+  - name: ednxzu.manage_repositories
+  - name: ednxzu.manage_apt_packages
diff --git a/tasks/prerequisites.yml b/tasks/prerequisites.yml
index 16819ea..f1bce54 100644
--- a/tasks/prerequisites.yml
+++ b/tasks/prerequisites.yml
@@ -1,14 +1,5 @@
 ---
 # task/prerequisites file for renew_nomad_certificates
-- name: "Install required roles"
-  ansible.builtin.command:
-    cmd: "ansible-galaxy install {{ item }}"
-  loop: "{{ renew_nomad_certificates_prerequisites_roles }}"
-  changed_when: false
-  become: false
-  delegate_to: localhost
-  run_once: true
-
 - name: "Create directory {{ renew_nomad_certificates_config_dir }}"
   ansible.builtin.file:
     path: "{{ renew_nomad_certificates_config_dir }}"
diff --git a/vars/main.yml b/vars/main.yml
index 4ee0df8..2d1ebb2 100644
--- a/vars/main.yml
+++ b/vars/main.yml
@@ -1,8 +1,5 @@
 ---
 # vars file for renew_nomad_certificates
-renew_nomad_certificates_prerequisites_roles:
-  - ednxzu.manage_repositories
-  - ednxzu.manage_apt_packages
 renew_nomad_certificates_repository:
   - uri: "https://apt.releases.hashicorp.com"
     gpg_key: "https://apt.releases.hashicorp.com/gpg"