From 3c1be4d599b11063785ad56431960c73880a9c3c Mon Sep 17 00:00:00 2001 From: Bertrand Lanson Date: Sun, 3 Dec 2023 17:45:22 +0100 Subject: [PATCH] feat: remove become from role --- handlers/main.yml | 1 - molecule/default/converge.yml | 1 + molecule/default/verify.yml | 3 ++- molecule/default_vagrant/converge.yml | 1 + molecule/default_vagrant/verify.yml | 1 + molecule/with_custom_packages/converge.yml | 1 + molecule/with_custom_packages/verify.yml | 3 ++- molecule/with_custom_packages_vagrant/converge.yml | 1 + molecule/with_custom_packages_vagrant/verify.yml | 1 + tasks/main.yml | 2 -- 10 files changed, 10 insertions(+), 5 deletions(-) diff --git a/handlers/main.yml b/handlers/main.yml index 187617f..a8e24d1 100644 --- a/handlers/main.yml +++ b/handlers/main.yml @@ -3,5 +3,4 @@ - name: "Remove unnecessary dependencies" ansible.builtin.apt: autoremove: yes - become: true listen: "apt-autoremove" diff --git a/molecule/default/converge.yml b/molecule/default/converge.yml index ccfe14b..f6d30d9 100644 --- a/molecule/default/converge.yml +++ b/molecule/default/converge.yml @@ -1,6 +1,7 @@ --- - name: Converge hosts: all + become: true tasks: - name: "Include ednxzu.manage_apt_packages" ansible.builtin.include_role: diff --git a/molecule/default/verify.yml b/molecule/default/verify.yml index 9661d59..ccab792 100644 --- a/molecule/default/verify.yml +++ b/molecule/default/verify.yml @@ -1,7 +1,8 @@ --- - name: Verify hosts: all - gather_facts: false + gather_facts: true + become: true tasks: - name: "Test: file /etc/hosts" block: diff --git a/molecule/default_vagrant/converge.yml b/molecule/default_vagrant/converge.yml index ccfe14b..f6d30d9 100644 --- a/molecule/default_vagrant/converge.yml +++ b/molecule/default_vagrant/converge.yml @@ -1,6 +1,7 @@ --- - name: Converge hosts: all + become: true tasks: - name: "Include ednxzu.manage_apt_packages" ansible.builtin.include_role: diff --git a/molecule/default_vagrant/verify.yml b/molecule/default_vagrant/verify.yml index afbf05e..11070c7 100644 --- a/molecule/default_vagrant/verify.yml +++ b/molecule/default_vagrant/verify.yml @@ -2,6 +2,7 @@ - name: Verify hosts: all gather_facts: true + become: true tasks: - name: "Test: file /etc/hosts" block: diff --git a/molecule/with_custom_packages/converge.yml b/molecule/with_custom_packages/converge.yml index ccfe14b..f6d30d9 100644 --- a/molecule/with_custom_packages/converge.yml +++ b/molecule/with_custom_packages/converge.yml @@ -1,6 +1,7 @@ --- - name: Converge hosts: all + become: true tasks: - name: "Include ednxzu.manage_apt_packages" ansible.builtin.include_role: diff --git a/molecule/with_custom_packages/verify.yml b/molecule/with_custom_packages/verify.yml index 2a9a100..d0323a7 100644 --- a/molecule/with_custom_packages/verify.yml +++ b/molecule/with_custom_packages/verify.yml @@ -1,7 +1,8 @@ --- - name: Verify hosts: all - gather_facts: false + gather_facts: true + become: true tasks: - name: "Test: file /etc/hosts" block: diff --git a/molecule/with_custom_packages_vagrant/converge.yml b/molecule/with_custom_packages_vagrant/converge.yml index ccfe14b..f6d30d9 100644 --- a/molecule/with_custom_packages_vagrant/converge.yml +++ b/molecule/with_custom_packages_vagrant/converge.yml @@ -1,6 +1,7 @@ --- - name: Converge hosts: all + become: true tasks: - name: "Include ednxzu.manage_apt_packages" ansible.builtin.include_role: diff --git a/molecule/with_custom_packages_vagrant/verify.yml b/molecule/with_custom_packages_vagrant/verify.yml index 97610f0..a7a429a 100644 --- a/molecule/with_custom_packages_vagrant/verify.yml +++ b/molecule/with_custom_packages_vagrant/verify.yml @@ -2,6 +2,7 @@ - name: Verify hosts: all gather_facts: true + become: true tasks: - name: "Test: file /etc/hosts" block: diff --git a/tasks/main.yml b/tasks/main.yml index fe70706..ec72f81 100644 --- a/tasks/main.yml +++ b/tasks/main.yml @@ -4,7 +4,6 @@ ansible.builtin.apt: update_cache: yes cache_valid_time: "{{ manage_apt_packages_apt_cache_time }}" - become: true - name: "Install/remove required apt packages" ansible.builtin.apt: @@ -15,4 +14,3 @@ when: manage_apt_packages_list is defined and manage_apt_packages_list not in [None, ''] notify: "apt-autoremove" - become: true